fix: pass valid locale for number formatting [DHIS2-17709] #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1352--dhis2-settings.netlify.app |
tomzemp
added a commit
that referenced
this pull request
Jul 15, 2024
tomzemp
added a commit
that referenced
this pull request
Jul 15, 2024
This was referenced Jul 15, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jul 15, 2024
## [100.2.1](v100.2.0...v100.2.1) (2024-07-15) ### Bug Fixes * pass valid locale for number formatting [DHIS2-17709] ([#1352](#1352)) ([460a87a](460a87a))
|
🎉 This PR is included in version 100.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-17709
Before
After
Tests
Automated: The app has no automated tests, so I'm not adding any with this PR 🤠
Manual: Tested app with various languages. Because of the existing logic of the number formatting, it is only applied on some number and there are some surprising variations:
Arabic (Sudan)) return Arabic formatted numbers (e.g.٢٠٠٬٠٠٠instead of200,000), but Arabic itself returns200,000. I checked with Alaa and she said in Sudan, they're used interchangeably; in Egypt people prefer٢٠٠٬٠٠٠)In both cases, I think it's probably okay to leave with what we have here, rather than make (additional) arbitrary exceptions.
also manually tested the
parseLocalefunction that was added to returnlanguage-locale, e.g. some results: